[llvm-commits] [llvm] r133412 - in /llvm/trunk: include/llvm/Constants.h lib/Analysis/ConstantFolding.cpp lib/AsmParser/LLParser.cpp lib/Bitcode/Reader/BitcodeReader.cpp lib/CodeGen/ShadowStackGC.cpp lib/Transforms/IPO/GlobalOpt.cpp lib/Transform

[Chris Lattner]

On Jun 21, 2011, at 12:22 AM, Jay Foad wrote:

>>> Patch 1 extends ConstantUniqueMap with a new template parameter
>>> ValRefType, representing a const reference to ValType. Normally this
>>> would just be const ValType&, but when ValType is a std::vector, we
>>> want to use ArrayRef as the reference type.
> 
>> Wow, looks great to me Jay
> 
> Just to double check, are you OK with me adding the conversion operator
> 
>  ArrayRef<T>::operator std::vector<T>() const;

I'm ok with it if there is no no other way, but..

> And should I remove the now redundant method which just did the same thing:
> 
>  std::vector<T> ArrayRef<T>::vec() const;

I'd prefer to keep this.

-Chris