[llvm-commits] [llvm] r133286 - in /llvm/trunk: include/llvm/MC/MCStreamer.h include/llvm/Target/TargetRegistry.h lib/CodeGen/LLVMTargetMachine.cpp lib/MC/MCAsmStreamer.cpp lib/Target/PTX/PTXMCAsmStreamer.cpp lib/Target/PTX/PTXTargetMachine.cpp tools/llvm-mc/llvm-mc.cpp

[Chris Lattner]

On Jun 17, 2011, at 1:35 PM, Bill Wendling wrote:

> Author: void
> Date: Fri Jun 17 15:35:21 2011
> New Revision: 133286
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=133286&view=rev
> Log:
> Add an option that allows one to "decode" the LSDA.
> 
> The LSDA is a bit difficult for the non-initiated to read. Even with comments,
> it's not always clear what's going on. This wraps the ASM streamer in a class
> that retains the LSDA and then emits a human-readable description of what's
> going on in it.

Spiffy.  Why is this a new set of flags?  Can't this just be tied to verbose asm?  I don't see any reason to have -decode-mc-lsda/-decode-lsda or to pass it down through the APIs as a bool.  Also, why is this implemented by subclassing MCAsmStreamer?  Can't the code generator just emit this as verbose asm comments instead of reconstructing it?

-Chris