[llvm-commits] [llvm] r132621 - in /llvm/trunk: test/TableGen/SetTheory.td utils/TableGen/CMakeLists.txt utils/TableGen/SetTheory.cpp utils/TableGen/SetTheory.h utils/TableGen/TableGen.cpp

[Nick Lewycky]

Sean Hunt wrote:
> On 06/03/11 21:11, Jakob Stoklund Olesen wrote:
>> +  /// Operator - A callback representing a DAG operator.
>> +  struct Operator {
>> +    /// apply - Apply this operator to Expr's arguments and insert the result
>> +    /// in Elts.
>> +    virtual void apply(SetTheory&, DagInit *Expr, RecSet&Elts) =0;
>> +  };
>> +
>> +  /// Expander - A callback function that can transform a Record representing a
>> +  /// set into a fully expanded list of elements. Expanders provide a way for
>> +  /// users to define named sets that can be used in DAG expressions.
>> +  struct Expander {
>> +    virtual void expand(SetTheory&, Record*, RecSet&Elts) =0;
>> +  };
>
> These are triggering -Wno-virtual-destructor warnings.

Furthermore, I'm seeing these:

SetTheory.cpp:69:8: warning: ‘virtual 
void<unnamed>::SetIntBinOp::apply(llvm::SetTheory&, llvm::DagInit*, 
<unnamed>::RecSet&)’ was hidden
SetTheory.cpp:83:8: warning:   by ‘virtual 
void<unnamed>::ShlOp::apply(llvm::SetTheory&, llvm::DagInit*, 
<unnamed>::RecSet&, int64_t, <unnamed>::RecSet&)’
SetTheory.cpp:69:8: warning: ‘virtual 
void<unnamed>::SetIntBinOp::apply(llvm::SetTheory&, llvm::DagInit*, 
<unnamed>::RecSet&)’ was hidden
SetTheory.cpp:95:8: warning:   by ‘virtual 
void<unnamed>::TruncOp::apply(llvm::SetTheory&, llvm::DagInit*, 
<unnamed>::RecSet&, int64_t, <unnamed>::RecSet&)’
SetTheory.cpp:69:8: warning: ‘virtual 
void<unnamed>::SetIntBinOp::apply(llvm::SetTheory&, llvm::DagInit*, 
<unnamed>::RecSet&)’ was hidden
SetTheory.cpp:112:8: warning:   by ‘virtual 
void<unnamed>::RotOp::apply(llvm::SetTheory&, llvm::DagInit*, 
<unnamed>::RecSet&, int64_t, <unnamed>::RecSet&)’
SetTheory.cpp:69:8: warning: ‘virtual 
void<unnamed>::SetIntBinOp::apply(llvm::SetTheory&, llvm::DagInit*, 
<unnamed>::RecSet&)’ was hidden
SetTheory.cpp:131:8: warning:   by ‘virtual 
void<unnamed>::DecimateOp::apply(llvm::SetTheory&, llvm::DagInit*, 
<unnamed>::RecSet&, int64_t, <unnamed>::RecSet&)’


>
> Sean
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>