[llvm-commits] [llvm] r132590 - in /llvm/trunk: lib/VMCore/InlineAsm.cpp test/CodeGen/ARM/inlineasm3.ll

Eric Christopher echristo at apple.com
Fri Jun 3 13:44:53 PDT 2011


Author: echristo
Date: Fri Jun  3 15:44:52 2011
New Revision: 132590

URL: http://llvm.org/viewvc/llvm-project?rev=132590&view=rev
Log:
Fix an off by one error.

Part of rdar://9037836 and rdar://9119939

Modified:
    llvm/trunk/lib/VMCore/InlineAsm.cpp
    llvm/trunk/test/CodeGen/ARM/inlineasm3.ll

Modified: llvm/trunk/lib/VMCore/InlineAsm.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/InlineAsm.cpp?rev=132590&r1=132589&r2=132590&view=diff
==============================================================================
--- llvm/trunk/lib/VMCore/InlineAsm.cpp (original)
+++ llvm/trunk/lib/VMCore/InlineAsm.cpp Fri Jun  3 15:44:52 2011
@@ -185,11 +185,10 @@
       // Multi-letter constraint
       // These will only occur with the existing multiple alternative
       // constraints and so we can use the isalpha loop below.
-      StringRef::iterator ConStart = I;
+      StringRef::iterator ConStart = ++I;
       while (I != E && isalpha(*I))
         ++I;
       pCodes->push_back(std::string(ConStart, I));
-      ++I;
     } else {
       // Single letter constraint.
       pCodes->push_back(std::string(I, I+1));

Modified: llvm/trunk/test/CodeGen/ARM/inlineasm3.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/inlineasm3.ll?rev=132590&r1=132589&r2=132590&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/inlineasm3.ll (original)
+++ llvm/trunk/test/CodeGen/ARM/inlineasm3.ll Fri Jun  3 15:44:52 2011
@@ -41,3 +41,12 @@
 tail call void asm sideeffect "flds s15, $0 \0A", "^Uv|m,~{s15}"(float 1.000000e+00) nounwind
 ret i32 0
 }
+
+; Radar 9037836 & 9119939
+
+ at k.2126 = internal unnamed_addr global float 1.000000e+00
+define i32 @t4() nounwind {
+entry:
+call void asm sideeffect "flds s15, $0 \0A", "*^Uv,~{s15}"(float* @k.2126) nounwind
+ret i32 0
+}





More information about the llvm-commits mailing list