[llvm-commits] Fix ARM instruction LDMIA_RET

Renato Golin rengolin at systemcall.org
Fri May 27 01:31:56 PDT 2011


On 26 May 2011 19:37, Danil Malyshev <dmalyshev at accesssoftek.com> wrote:
>> Do you have a simple test (ll -> s) to add?
>
> The updated patch with a regress test is attached.

Hi Damil,

Aside from the rest of the discussion, your test is not using the
right approach.

When running lit, you don't need to grep things in the RUN line, but
rather use the CHECK* directives to select patters.

Lit supports regular expressions, variables, check-negative (grep -v),
check-next (make sure it's in the next line from previous match), etc.
Besides, you get to write the CHECK lines right on top of the code
lines, which makes it much easier to understand what the test is
checking against.

Look at the LLVM test directory for a lot of examples...

cheers,
--renato



More information about the llvm-commits mailing list