[llvm-commits] Fix ARM instruction LDMIA_RET

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Thu May 26 13:22:16 PDT 2011


On Thu, May 26, 2011 at 5:05 PM, Danil Malyshev
<dmalyshev at accesssoftek.com> wrote:
> Hello Bruno
>
>> Or did I miss something?
>
> Both ARMAsmPrinter and ARMInstPrinter handle a special case for ARM::LDMIA_RET instead of using TableGen.
>
> My goal was to fix the TableGen definition for LDMIA_RET and validate the TableGen usage.

Like Cameron said, this instruction should definitely be a pseudo
instruction. LDMIA_* family of instructions, which are the true ones,
already have the right encoding. Why do you need to add encoding for
this pseudo instruction? It's going to be translated later anyway,
right?

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc



More information about the llvm-commits mailing list