[llvm-commits] ARM EABI memset

[Anton Korobeynikov]

Hi Renato,

> This patch includes the lib call naming, specially lowering when in
> EABI mode and additional test to make sure we get the right behaviour
> on both modes.
>
> Please, let me know if it's good, so I can commit.
Patch looks good. Some minor stuff (mostly due to style):

+  if (!Subtarget->isAAPCS_ABI()) {
+    return SDValue();
+  }
No braces here

+    cast<Type>(TLI.getTargetData()->getIntPtrType(*DAG.getContext()));
You don't need to call cast<> here, because getIntPtrType()
essentially returns Type.

+                    Type::getVoidTy(*DAG.getContext()), /* return type */
Please use C++ comments.

Otherwise - ok with these changes.

Thanks!

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University