[llvm-commits] [llvm] r131516 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineCalls.cpp lib/Transforms/InstCombine/InstructionCombining.cpp test/Transforms/InstCombine/call.ll

[Frits van Bommel]

On Wed, May 18, 2011 at 11:04 PM, Devang Patel <dpatel at apple.com> wrote:
> On May 18, 2011, at 12:44 AM, Frits van Bommel wrote:
>> On Wed, May 18, 2011 at 3:28 AM, Eli Friedman <eli.friedman at gmail.com> wrote:
>>>     // Now that we have an instruction, try combining it to simplify it.
>>>     Builder->SetInsertPoint(I->getParent(), I);
>>> +    Builder->SetCurrentDebugLocation(I->getDebugLoc());
>>
>> This would look even nicer if the IRBuilder::SetInsertPoint()
>> overloads that take an Instruction* did this automatically :).
>
> Good idea! r131575.

The idea was to then also remove that explicit
Builder->SetCurrentDebugLocation() call :).
(Same goes for occurrences of this pattern in other passes, if any)