[llvm-commits] [llvm] r131186 - in /llvm/trunk: include/llvm/Support/Program.h lib/Support/Program.cpp lib/Support/Unix/Program.inc tools/bugpoint/ExecutionDriver.cpp tools/bugpoint/Miscompilation.cpp tools/bugpoint/ToolRunner.cpp

[Dan Gohman]

> --- llvm/trunk/include/llvm/Support/Program.h (original)
> +++ llvm/trunk/include/llvm/Support/Program.h Wed May 11 11:31:24 2011
> @@ -96,9 +96,11 @@
>       ///< expires, the child is killed and this call returns. If zero,
>       ///< this function will wait until the child finishes or forever if
>       ///< it doesn't.
> -      std::string* ErrMsg ///< If non-zero, provides a pointer to a string
> +      std::string* ErrMsg, ///< If non-zero, provides a pointer to a string
>       ///< instance in which error messages will be returned. If the string
>       ///< is non-empty upon return an error occurred while waiting.
> +      const char *SignalPrefix ///< If non-zero, provides a prefix to be
> +      ///< prepended to ErrMsg if the process is terminated abnormally.
>       );

This function is documented to return a negative value if the process is
terminated abnormally. Shouldn't the task of producing a pretty error
message belong to client code, rather than being built into these low-level
support functions?

Dan