[llvm-commits] [llvm] r130470 - in /llvm/trunk: CMakeLists.txt cmake/modules/AddLLVM.cmake cmake/modules/LLVMLibDeps.cmake runtime/libprofile/CMakeLists.txt runtime/libprofile/Makefile utils/profile.pl

Óscar Fuentes ofv at wanadoo.es
Thu Apr 28 20:33:01 PDT 2011


Hello Nick.

Nick Lewycky <nicholas at mxc.ca> writes:

[snip]

> Oscar, this touches a change you made for EXCLUDE_FROM_ALL support -- I think
> I've done the right thing, but please let me know (or fix and commit) if not!

[snip]

> -      set_target_properties(profile_rt PROPERTIES EXCLUDE_FROM_ALL ON)
> +      set_target_properties( ${name} PROPERTIES EXCLUDE_FROM_ALL ON)

That was a copy&pasto. Thanks for fixing it.

The rest of the change looks ok, but please commit modifications to the
library dependencies (LLVMLibDeps.txt) on its own revision, or together
with the changes that produces the modification on the dependencies.

[snip]




More information about the llvm-commits mailing list