[llvm-commits] [poolalloc] r130089 - /poolalloc/trunk/lib/AssistDS/TypeChecks.cpp

Nick Lewycky nicholas at mxc.ca
Sun Apr 24 14:16:20 PDT 2011


Arushi Aggarwal wrote:
> Author: aggarwa4
> Date: Sun Apr 24 09:13:22 2011
> New Revision: 130089
>
> URL: http://llvm.org/viewvc/llvm-project?rev=130089&view=rev
> Log:
> First convert to std::string and then compare.

Why? getNameStr() returns an std::string not a char*, so this should 
have no semantic change.

>
> Modified:
>      poolalloc/trunk/lib/AssistDS/TypeChecks.cpp
>
> Modified: poolalloc/trunk/lib/AssistDS/TypeChecks.cpp
> URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/lib/AssistDS/TypeChecks.cpp?rev=130089&r1=130088&r2=130089&view=diff
> ==============================================================================
> --- poolalloc/trunk/lib/AssistDS/TypeChecks.cpp (original)
> +++ poolalloc/trunk/lib/AssistDS/TypeChecks.cpp Sun Apr 24 09:13:22 2011
> @@ -312,7 +312,7 @@
>           CallInst::Create(F, Args.begin(), Args.end(), "", I);
>           break;
>         }
> -    } else if(F->getNameStr() == "realloc") {
> +    } else if(F->getNameStr() ==  std::string("realloc")) {
>         CastInst *BCI_Src = BitCastInst::CreatePointerCast(I->getOperand(1), VoidPtrTy);
>         CastInst *BCI_Dest = BitCastInst::CreatePointerCast(I, VoidPtrTy);
>         BCI_Src->insertAfter(I);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list