[llvm-commits] [llvm] r129842 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp test/CodeGen/ARM/umulo-32.ll

[Eric Christopher]

On Apr 20, 2011, at 9:36 AM, Chris Lattner wrote:

> 
> On Apr 19, 2011, at 6:19 PM, Eric Christopher wrote:
> 
>> Author: echristo
>> Date: Tue Apr 19 20:19:45 2011
>> New Revision: 129842
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=129842&view=rev
>> Log:
>> Rewrite the expander for umulo/smulo to remember to sign extend the input
>> manually and pass all (now) 4 arguments to the mul libcall. Add a new
>> ExpandLibCall for just this (copied gratuitously from type legalization).
> 
> Instead of copying the code over, could it be moved someplace common?  Maybe become a method on SelectionDAG itself or something.

Totally agree.

I'll see what I can do.

-eric