[llvm-commits] [llvm] r129040 - /llvm/trunk/lib/VMCore/IRBuilder.cpp

[Chris Lattner]

On Apr 8, 2011, at 1:54 AM, Duncan Sands wrote:

> Hi Nick,
> 
>>>> Set unnamed_addr on strings created through the IRBuilder.
>>> 
>>> why is this correct? Aren't you inserting C semantics into the IRBuilder?
>> 
>> Why is it wrong?
> 
> because it supposes that the language being compiled allows two strings with the
> same contents to be merged.  I'm actually fine with this change as long as it is
> documented.  Shall I add an appropriate blurb to IRBuilder.h or would you rather
> do it?

I agree that it should be documented, but I agree with the change.  IRBuilder is supposed to be a convenience, so it should do whatever is right for "most" clients.

-Chris