[llvm-commits] [llvm] r128246 - in /llvm/trunk: test/MC/Disassembler/ARM/thumb-tests.txt utils/TableGen/ARMDecoderEmitter.cpp

[Johnny Chen]

let mayLoad = 1, hasExtraDefRegAllocReq = 1 in
defm tLDM : thumb_ldst_mult<"ldm", IIC_iLoad_m, IIC_iLoad_mu,
                            {1,1,0,0,1,?}, 1>;

let mayStore = 1, hasExtraSrcRegAllocReq = 1 in
defm tSTM : thumb_ldst_mult<"stm", IIC_iStore_m, IIC_iStore_mu,
                            {1,1,0,0,0,?}, 0>;

tLDM uses the defm nicely, but tSTMIA doesn't belong.

On Mar 24, 2011, at 5:28 PM, Eli Friedman wrote:

> On Thu, Mar 24, 2011 at 4:21 PM, Johnny Chen <johnny.chen at apple.com> wrote:
>> Author: johnny
>> Date: Thu Mar 24 18:21:14 2011
>> New Revision: 128246
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=128246&view=rev
>> Log:
>> The ARM disassembler was confused with the 16-bit tSTMIA instruction.
>> According to A8.6.189 STM/STMIA/STMEA (Encoding T1), there's only tSTMIA_UPD available.
>> Ignore tSTMIA for the decoder emitter and add a test case for that.
> 
> Why do we have a definition for an instruction which doesn't exist?
> 
> -Eli