[llvm-commits] [llvm] r128020 - /llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp

Evan Cheng evan.cheng at apple.com
Tue Mar 22 10:44:31 PDT 2011


Why are you using #if 0 #endif?

Evan

On Mar 21, 2011, at 2:08 PM, Bill Wendling wrote:

> Author: void
> Date: Mon Mar 21 16:08:27 2011
> New Revision: 128020
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=128020&view=rev
> Log:
> Call static functions so that they aren't left unused.
> 
> Modified:
>    llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp
> 
> Modified: llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp?rev=128020&r1=128019&r2=128020&view=diff
> ==============================================================================
> --- llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp (original)
> +++ llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp Mon Mar 21 16:08:27 2011
> @@ -847,7 +847,6 @@
>     AliasMap[getQualifiedName(Op->getDef())].push_back(Alias);
>   }
> 
> -#if 0
>   // A map of which conditions need to be met for each instruction operand
>   // before it can be matched to the mnemonic.
>   std::map<std::string, std::vector<IAPrinter*> > IAPrinterMap;
> @@ -930,15 +929,18 @@
>       if (CantHandle) continue;
>       IAPrinterMap[I->first].push_back(IAP);
> 
> +#if 0
>       O.indent(4) << "// " << I->first << '\n';
>       O.indent(4);
>       IAP->print(O);
> +#endif
>     }
>   }
> 
> +  O << "#if 0\n";
>   EmitSubtargetFeatureFlagEnumeration(AWI, O);
>   EmitComputeAvailableFeatures(AWI, AsmWriter, Target, O);
> -#endif
> +  O << "#endif\n\n";
> 
>   O << "bool " << Target.getName() << ClassName
>     << "::printAliasInstr(const " << MachineInstrClassName
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list