[llvm-commits] [llvm] r127988 - in /llvm/trunk/utils/TableGen: AsmWriterEmitter.cpp AsmWriterEmitter.h

[Eric Christopher]

On Mar 21, 2011, at 2:13 PM, Bill Wendling wrote:

> On Mar 21, 2011, at 11:48 AM, Nick Lewycky wrote:
> 
>> Hi Bill,
>> 
>> This broke the build for us because we use -Wunused-function -Werror. 
>> 
>> llvm/utils/TableGen/AsmWriterEmitter.cpp:714: error: 'void EmitSubtargetFeatureFlagEnumeration(<unnamed>::AsmWriterInfo&, llvm::raw_ostream&)' defined but not used [-Wunused-function]
>> 
>> llvm/utils/TableGen/AsmWriterEmitter.cpp:735: error: 'void EmitComputeAvailableFeatures(<unnamed>::AsmWriterInfo&, llvm::Record*, llvm::CodeGenTarget&, llvm::raw_ostream&)' defined but not used [-Wunused-function]
>> 
>> Would you be okay with waiting until you have the callers written before submitting? Or at least breaking it up in a different sort of way?
>> 
> Hi Nick,
> 
> You did what I was hoping you wouldn't do. :-) I fixed it with this r128020. I'm sorry about the breakage.

Yeah, clang whines about it too :)

-eric