[llvm-commits] patch: the default argument to "dmb" is "sy"

[Bruno Cardoso Lopes]

Hi Nick,

I agree with Jim, and besides that, could you add the test together
with the other "dmb" checks (and also check for the encoding)?

On Thu, Mar 17, 2011 at 3:17 PM, Jim Grosbach <grosbach at apple.com> wrote:
> Hi Nick,
>
> How would an absent operand get to that default? I would expect the lexer to have returned EndOfStatement there, and there's an assert above it that there exists an operand and that it's an identifier value. That switch then checks for the identifier being a legal value.
>
> Perhaps instead add an explicit case to check for EndOfStatement and add the default value if that's the case?
>
> -Jim
>
> On Mar 16, 2011, at 5:56 PM, Nick Lewycky wrote:
>
>> The attached patch changes ARM MC to accept "dmb" and assemble it as "dmb sy". According to this page:
>>   http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0489c/CIHGHHIE.html
>> that's the right thing to do.
>>
>> Please review!
>>
>> Nick
>>
>> <arm-dmb-sy.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc