[llvm-commits] LCSSA avoiding creation of unused PHI nodes

Andrew Clinton ajclinto at gmail.com
Mon Mar 14 22:15:09 PDT 2011


No problem.  Here is the updated patch.

On Tue, Mar 15, 2011 at 12:24 AM, Cameron Zwarich <zwarich at apple.com> wrote:
> Sorry to be a pain, but do you want to use the new FileCheck style of test here?
>
> I will try to take a look at the LoopSimplify patch later today or tomorrow. There was something I wanted to test with it. It is unfortunate that block layout is so brittle right now, but that's the way it is for the time being.
>
> Cameron
>
> On Mar 14, 2011, at 9:18 PM, Andrew Clinton wrote:
>
>> Thanks for the review - here is the update.
>>
>> Could you also review/commit the updated loop-simplify patch that I
>> send to the llvm-commits list?
>>
>> On Mon, Mar 14, 2011 at 11:50 PM, Cameron Zwarich <zwarich at apple.com> wrote:
>>> I would add a test for this. Also, AvailablePHIs is a bit of a vague name. Maybe AddedPHIs would be better? Other than that, it looks good.
>>>
>>> Cameron
>> <lcssa_unused_phis.diff>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lcssa_unused_phis.diff
Type: text/x-patch
Size: 2592 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110315/a9b16644/attachment.bin>


More information about the llvm-commits mailing list