[llvm-commits] [llvm] r127097 - /llvm/trunk/include/llvm/CodeGen/MachineInstr.h

[Villmow, Micah]

> -----Original Message-----
> From: anton at korobeynikov.info [mailto:anton at korobeynikov.info] On
> Behalf Of Anton Korobeynikov
> Sent: Tuesday, March 08, 2011 1:30 PM
> To: Villmow, Micah
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [llvm] r127097 -
> /llvm/trunk/include/llvm/CodeGen/MachineInstr.h
> 
> Hello Micah,
> 
> >  Is there a reason why this is being shortened to 8 bits?
> Yes. See next commits. Basically the field was splited in order to
> introduce the MIFlags field and not to increase the size of
> MachineInstr class.
> Given that currently the only user of AsmPrinter flags occupied only 1
> bit this was considered as a safe procedure.
> 
> > I currently need all 16 bits in AMD's backend and this would break
> our backend if we sync to past this changelist.
> Well, you can always increase the size of MachineInstr. There are
> bunch of other ways to break your code since noone saw it :)
[Villmow, Micah] Yeah I know, we are working on that. Increasing the size is a maintenance nightmare.
> 
> --
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University