[llvm-commits] [dragonegg] r127081 - /dragonegg/trunk/llvm-internal.h

[Duncan Sands]

Author: baldrick
Date: Sat Mar  5 06:44:12 2011
New Revision: 127081

URL: http://llvm.org/viewvc/llvm-project?rev=127081&view=rev
Log:
Add a note on some naughty methods explaining why they should be eliminated
one day.

Modified:
    dragonegg/trunk/llvm-internal.h

Modified: dragonegg/trunk/llvm-internal.h
URL: http://llvm.org/viewvc/llvm-project/dragonegg/trunk/llvm-internal.h?rev=127081&r1=127080&r2=127081&view=diff
==============================================================================
--- dragonegg/trunk/llvm-internal.h (original)
+++ dragonegg/trunk/llvm-internal.h Sat Mar  5 06:44:12 2011
@@ -783,16 +783,23 @@
   Constant *EmitRegisterConstant(tree_node *reg);
 
   /// Mem2Reg - Convert a value of in-memory type (that given by ConvertType)
-  /// to in-register type (that given by GetRegType).
+  /// to in-register type (that given by GetRegType).  TODO: Eliminate these
+  /// methods: "memory" values should never be held in registers.  Currently
+  /// this is mainly used for marshalling function parameters and return values,
+  /// but that should be completely independent of the reg vs mem value logic.
   Value *Mem2Reg(Value *V, tree_node *type, LLVMBuilder &Builder);
   Constant *Mem2Reg(Constant *C, tree_node *type, TargetFolder &Folder);
 
   /// Reg2Mem - Convert a value of in-register type (that given by GetRegType)
-  /// to in-memory type (that given by ConvertType).
+  /// to in-memory type (that given by ConvertType).  TODO: Eliminate this
+  /// method: "memory" values should never be held in registers.  Currently
+  /// this is mainly used for marshalling function parameters and return values,
+  /// but that should be completely independent of the reg vs mem value logic.
   Value *Reg2Mem(Value *V, tree_node *type, LLVMBuilder &Builder);
 
   /// EmitMemory - Convert the specified gimple register or local constant of
   /// register type to an LLVM value with in-memory type (given by ConvertType).
+  /// TODO: Eliminate this method, see Mem2Reg and Reg2Mem above.
   Value *EmitMemory(tree_node *reg);
 
   /// LoadRegisterFromMemory - Loads a value of the given scalar GCC type from