[llvm-commits] [llvm] r126964 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp lib/CodeGen/SelectionDAG/LegalizeTypes.h test/CodeGen/X86/umulo-64.ll

[Richard Osborne]

On 04/03/11 00:21, Eric Christopher wrote:
> On Mar 3, 2011, at 4:16 PM, Eric Christopher wrote:
>
>> Here's a simple patch that fixes the problem in something resembling correctness, but uses divide to do it - so yeah, performance?
>>
>> Thoughts?
> Uh, other than divide by zero.
>
> *fixes*
>
> -eric
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
It's not just divide by zero you need to worry about. For the signed 
case LHS = -1, RHS = -2^31 would also cause problems.

-- 
Richard Osborne | XMOS
http://www.xmos.com