[llvm-commits] [llvm] r126714 - in /llvm/trunk: include/llvm/Constants.h lib/VMCore/Constants.cpp

[Frits van Bommel]

On Tue, Mar 1, 2011 at 12:53 AM, Talin <viridia at gmail.com> wrote:
> +Constant* ConstantStruct::get(LLVMContext &Context, bool Packed,
> +                              Constant * Val, ...) {
> +  va_list ap;
> +  std::vector<Constant*> Values;
> +  va_start(ap, Val);
> +  while (Val) {
> +    Values.push_back(Val);
> +    Val = va_arg(ap, llvm::Constant*);
> +  }

Shouldn't there technically be a va_end right about here?
I'm not aware of any platform where that actually does anything, but
it can't hurt either...

> +  return get(Context, Values, Packed);
> +}