[llvm-commits] Code refactoring of MCELFStreamer.cpp and ELFObjectWriter.cpp

[Jason Kim]

On Fri, Feb 25, 2011 at 12:05 PM, Jan Sjodin <jan_sjodin at yahoo.com> wrote:
> Just to keep the code more object-oriented. If a sub-class (I intend to inherit
> from these classes) needs the functions, they will not be available if they are
> hidden as static functions.

Hi Jan,

Just out of curiosity, what do you plan to do with MCELF inheritance wise?
Thanks

-jason

>
> - Jan
>
>
> ----- Original Message ----
>> From: Rafael Avila de Espindola <rafael.espindola at gmail.com>
>> To: llvm-commits at cs.uiuc.edu
>> Sent: Fri, February 25, 2011 2:46:10 PM
>> Subject: Re: [llvm-commits] Code refactoring of MCELFStreamer.cpp and
>>ELFObjectWriter.cpp
>>
>> On 11-02-25 12:02 PM, Jan Sjodin wrote:
>> > Removed duplicated code by  putting shared functions in MCELF.h/cpp and made
>>the
>> > rest of the C-style  static functions static methods in the corresponding
>> >  classes.
>>
>> Moving the duplicated functions to a new file is OK, but why  convert the
>> function only used in the ELFObjectWriter to static  methods?
>>
>> > -  Jan
>>
>> Cheers,
>> Rafael
>> _______________________________________________
>> llvm-commits  mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>