[llvm-commits] [lto][patch] Remove weak attempt of tracking symbols defined in module level assembly

[Devang Patel]

On Feb 21, 2011, at 4:07 PM, Rafael Ávila de Espíndola wrote:

>> I may have missed some context here, but why is it a bug anywhere to
>> include asm global in symbols list ? The symbols list is the list of
>> the symbols linker would normally find in .o file if LTO is not
>> used.
> 
> It is not a bug to include it, if the included symbol is correct :-)
> 
> In a build of firefox I was seeing symbols whose names would start with
> a tab. A reduced testcase is
> 
> module asm "\09.if\093 < 10"
> module asm "\09.globl\09_ZN14nsXPTCStubBase5Stub3Ev"
> module asm "\09.endif"
> 
> While we can always push the hack a bit further, I don't see a way to
> get this right in general other then using MC. Since that is more work
> than I can do right now and since the hack doesn't add a lot of value on
> ELF, I would like to disable it for now unless we have a Mach-O target.

Ok.
-
Devang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110221/2264fcd1/attachment.html>