[llvm-commits] [llvm] r126147 - in /llvm/trunk/lib/Target/X86/Disassembler: X86Disassembler.cpp X86DisassemblerDecoder.h

[Chris Lattner]

On Feb 21, 2011, at 1:55 PM, Sean Callanan wrote:

> Author: spyffe
> Date: Mon Feb 21 15:55:05 2011
> New Revision: 126147
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=126147&view=rev
> Log:
> Fixed a bug in the X86 disassembler where a member of the
> X86 instruction decode structure was being interpreted as
> being in units of bits, although it is actually stored in
> units of bytes.

Hi Sean,

Please add a testcase to llvm/test/MC/Disassembler/X86/

-Chris

> 
> Modified:
>    llvm/trunk/lib/Target/X86/Disassembler/X86Disassembler.cpp
>    llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.h
> 
> Modified: llvm/trunk/lib/Target/X86/Disassembler/X86Disassembler.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/Disassembler/X86Disassembler.cpp?rev=126147&r1=126146&r2=126147&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/Disassembler/X86Disassembler.cpp (original)
> +++ llvm/trunk/lib/Target/X86/Disassembler/X86Disassembler.cpp Mon Feb 21 15:55:05 2011
> @@ -168,16 +168,16 @@
>     switch (insn.displacementSize) {
>     default:
>       break;
> -    case 8:
> +    case 1:
>       type = TYPE_MOFFS8;
>       break;
> -    case 16:
> +    case 2:
>       type = TYPE_MOFFS16;
>       break;
> -    case 32:
> +    case 4:
>       type = TYPE_MOFFS32;
>       break;
> -    case 64:
> +    case 8:
>       type = TYPE_MOFFS64;
>       break;
>     }
> 
> Modified: llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.h?rev=126147&r1=126146&r2=126147&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.h (original)
> +++ llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.h Mon Feb 21 15:55:05 2011
> @@ -399,7 +399,7 @@
>   /* The segment override type */
>   SegmentOverride segmentOverride;
> 
> -  /* Sizes of various critical pieces of data */
> +  /* Sizes of various critical pieces of data, in bytes */
>   uint8_t registerSize;
>   uint8_t addressSize;
>   uint8_t displacementSize;
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits