[llvm-commits] [llvm] r125470 - in /llvm/trunk: lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/CodeGen/SelectionDAG/TargetLowering.cpp lib/Target/ARM/ARMISelDAGToDAG.cpp lib/Target/X86/X86ISelDAGToDAG.cpp lib/Target/X86/X86ISelLowering.cpp test/Co

[Chris Lattner]

On Feb 13, 2011, at 2:45 PM, Frits van Bommel wrote:

> On Sun, Feb 13, 2011 at 11:25 PM, Chris Lattner <sabre at nondot.org> wrote:
>> +/// isBaseWithConstantOffset - Return true if the specified operand is an
>> +/// ISD::ADD with a ConstantSDNode on the right-hand side, or if it is an
>> +/// ISD::OR with a ConstantSDNode that is guaranteed to have the same
>> +/// semantics as an ADD.  This handles the equivalence:
>> +///     X|Cst == X+Cst iff X&~Cst = 0.
> 
> I think you mean 'iff X&Cst == 0'.
> Ditto for the header comment added in r125471.

Sigh, yes.  Fixed in r125481, thanks for the review!

-Chris