[llvm-commits] [llvm] r125393 - in /llvm/trunk: lib/VMCore/ConstantFold.cpp test/Transforms/InstCombine/bitcast-vec-uniform.ll test/Transforms/InstCombine/fold-vector-select.ll

[Nick Lewycky]

Duncan Sands wrote:
> Hi Nadav,
>
>> Thank you for catching this.
>>
>> The patch below fixes the problem. If it looks good to you I will commit it.
>
> why not teach getAllOnesValue to handle floating point types instead?

Further, it seems that if we're going to have Constant::getAllOnesValue 
then we should also have Constant->isAllOnesValue().

Nick