[llvm-commits] [llvm] r124995 - in /llvm/trunk: lib/Target/ARM/ARMAsmPrinter.cpp lib/Target/ARM/ARMBuildAttrs.h test/CodeGen/ARM/2010-09-29-mc-asm-header-test.ll test/CodeGen/ARM/2010-10-19-mc-elf-objheader.ll

[Jason Kim]

Hi Anton.


On Sun, Feb 6, 2011 at 5:44 PM, Anton Korobeynikov
<anton at korobeynikov.info> wrote:
> Hello Jason,
>
>> +  if (CPUString == "cortex-a8" ||
>> +      Subtarget->isCortexA8()) {
>> +    AttrEmitter->EmitTextAttribute(ARMBuildAttrs::CPU_name, "CORTEX-A8");
>> +    AttrEmitter->EmitAttribute(ARMBuildAttrs::CPU_arch, ARMBuildAttrs::v7);
>> +    AttrEmitter->EmitAttribute(ARMBuildAttrs::CPU_arch_profile,
>> +                               ARMBuildAttrs::ApplicationProfile);
>> +    AttrEmitter->EmitAttribute(ARMBuildAttrs::ARM_ISA_use,
>> +                               ARMBuildAttrs::Allowed);
>> +    AttrEmitter->EmitAttribute(ARMBuildAttrs::THUMB_ISA_use,
>> +                               ARMBuildAttrs::AllowThumb32);
>> +    // Fixme: figure out when this is emitted.
>> +    //AttrEmitter->EmitAttribute(ARMBuildAttrs::WMMX_arch,
>> +    //                           ARMBuildAttrs::AllowWMMXv1);
> Can't we deduce these attributes from -mattr stuff? I believe

I am not sure what you mean here. see below.

> subtarget has all necessary stuff wrt ISA and CPU arch. You might only
> need to do some custom stuff for profile.

This is a first cut approximation of what attributes gets emitted via
arm-gcc when cortex-a8 is selected,

>
> --
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University
>