[llvm-commits] Fix floating point numbers in tests on MinGW

NAKAMURA Takumi geek4civic at gmail.com
Fri Feb 4 01:36:34 PST 2011


Danil,

Your patch was effective, (I guess you have expected), only on mingw.
In fact, it is fine on mingw.

I cannot pick up your patch now yet. rationale...

  - It does not improve anything with msvc runtime and msvc build environment.
  - It would be useful on mingw for testing.
  - We expect identical output on standalone tools.
    (eg. llvm-dis, clang -emit-llvm, &c...)

Your patch is so simple but I am afraid of potentially hiding consistency.
I will wait for 2nd opinion.

Thank you!
...Takumi



More information about the llvm-commits mailing list