[llvm-commits] [llvm] r123990 - in /llvm/trunk: include/llvm/ADT/Triple.h lib/Support/Triple.cpp unittests/ADT/TripleTest.cpp

[Renato Golin]

On 23/01/11 13:26, Duncan Sands wrote:
> Maybe clang has other
> needs but if so I think it should build its own infrastructure (perhaps
> on top of the Triple logic) to take care of this.

All the problem I can think of are in Clang's IR generation and not
codegen/optimization.

The only thing I can think of that would require that information in the
codegen phase is to create the correct build attributes in the
asm/object file to hint the linker to bring the correct libraries, but
build attributes have been dismissed more than once and I don't want to
get into that topic again, soon.

I just assumed that, since Triple already had all information about OSs,
environments and everything, it was the right place to add more
OS/Environment logic so that all projects (including Clang) could use.

I personally don't think it's too much to add NoOS and NoEnvironment to
the Triple class, since many of the OSs would end up having the same
codegen anyway. But if you feel strongly about it, I can add the option
to a supposedly Clang's Triple class.

cheers,
--renato

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.