[llvm-commits] [llvm] r123252 - in /llvm/trunk/utils/Target: ./ ARM/ ARM/analyze-match-table.py

[Daniel Dunbar]

On Wed, Jan 12, 2011 at 1:19 AM, Renato Golin <Renato.Golin at arm.com> wrote:
> On 01/12/11 01:43, Chris Lattner wrote:
>>> McARM: Write a silly Python script to compute some hard coded info from the
>>> generated ARM match table, which is substantially more efficient than dealing
>>> with tblgen.
>>
>> Is this a short term hack?  This is really gross.
>
> I agree.

I do too, it is a hopefully short term hack. I'm still in the process
of figuring out how I want the ARM assembler parser to look like...

Pretend amongst yourselves that I never checked the script in, and
just added a lot of hard coded constants to the ARM assembler parser,
and comment on how those are really gross instead...

 - Daniel

>
> It's not clear what the script does, how it is used, if it is intended
> to replace tablegen magic just because it's faster/easier or because it
> has features tablegen don't, or because it's faster to develop in python
> than tablegen, how long will this script be in use and what are the
> steps to replace it one day, if any.
>
> Not to mention that it creates a precedence for further hacks, which
> might not be temporary themselves... ;)
>
> cheers,
> --renato
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>