[llvm-commits] [PATCH] Some tweaks (PathV2, Archive, &c)

[Michael Spencer]

They all look good to me except
"0002-lib-Archive-ArchiveWriter.cpp-Don-t-concatenate-.patch.txt". I
have a better fix for that which preserves the filename.

Please commit the rest. Thanks!

- Michael Spencer



On Mon, Jan 17, 2011 at 5:35 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Michael and guys,
>
> Four patches are here. Checked on Windows XP, Windows 7 and CentOS5.
> They are trivial, and feel free to commit them by yourself with
> appropriate approval,
> or improve them, please ;)
>
>
> [Win/posix]
>
> * 0002-lib-Archive-ArchiveWriter.cpp-Don-t-concatenate-.patch.txt
>
>  On Posix, we would see weird directories in the temporary directory.
>
>  eg.) /tmp/f8-d3-97-7c/home/chapuni/BUILD/llvm-static/test/Linker/Output
>
>  On Win32, make_unique() tried to make invalid directory and path.
>
>  eg.) 59-7f-5e-53C:/cygwin/home/....
>
>  For now, I got rid of adding prefix or suffix to the model to unique().
>
>
> [Win32]
>
> * 0001-lib-Support-Windows-Signals.inc-Showstopper-dial.patch.txt
>
>  On mingw and msvc, I think it would be enough. :)
>
> * 0003-Windows-PathV2.inc-MoveFileEx-can-behave-like-Po.patch.txt
>
>  On win32, we can use MoveFileEx().
>
> * 0004-Windows-PathV2.inc-For-CryptAcquireContext-CRYPT.patch.txt
>
>  On some circumstances (afaik some Windows XP), CryptAcquireContext
> to default would fail.
>  (On windows7, it succeeds)
>  CRYPT_VERIFYCONTEXT can provide a trivial context, I understand.
>
>  Anyway, I think Crypto API would be overkill for random number generation.
>
>
> ...Takumi
>