[llvm-commits] [llvm] r123294 - in /llvm/trunk: lib/MC/ELFObjectWriter.cpp lib/Target/ARM/ARMAsmBackend.cpp lib/Target/ARM/ARMAsmPrinter.cpp lib/Target/ARM/ARMFixupKinds.h lib/Target/ARM/ARMMCCodeEmitter.cpp test/MC/ARM/elf-movt.s

[Jason Kim]

On Wed, Jan 12, 2011 at 1:56 PM, Jim Grosbach <grosbach at apple.com> wrote:

> The value-kinds look like masks, but they're not consistently used that way, unfortunately. If you want to change them to work additively instead of a one-variant-kind-per-symbolref, that's great and I completely agree it's worth doing, but it really should be a separate patch. Until then, this isn't correct. Please revert this bit.

Ah. It turns out that I left out a part of the patch that gives
explicit value to the enums - I'll update the enum decls and fix.
Thanks for catching this. Yikes!

-jason