[llvm-commits] [patch] Only allow unnamed_addr in definitions

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Wed Jan 12 08:59:01 PST 2011


The attached patches changes llvm to only accept unnamed_addr in 
definitions and clang to not produce them in declarations.

I am not entirely convinced that we should do it. The reasons so far are

*) There is nothing for LLVM to do with the knowledge that a declaration 
might be merged in the future
*) It would require us to define what the linker should do on mismatched 
declarations and definitions. The correct answer would probably be 
"ignore the bit in the declaration and keep the definition one", which 
also suggest that we shouldn't have this in declarations.

OK?

Cheers,
Rafael
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: clang.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110112/5e5daed7/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: llvm.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110112/5e5daed7/attachment-0001.ksh>


More information about the llvm-commits mailing list