[llvm-commits] [PATCH] ARM bkpt instruction!

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Tue Jan 11 16:28:12 PST 2011


Hi Anton,

On Mon, Jan 10, 2011 at 5:39 PM, Anton Korobeynikov
<anton at korobeynikov.info> wrote:
> Hi Bruno,
>
>> This patch fix the asm parsing for the thumb1 bkpt instruction!
>> Ok to commit?
> Is it possible to make patch more generic somehow, e.g. for other
> non-predicable instructions (if any)?

The problem here is that the cond code operand is created during
ParseInstruction, while any MI info will only be available in
MatchAndEmitInstruction. With MI info we would be able to do something
better, for example: creating a TSFlag for Encoding16 or mark
instructions with a NonPredicable bit, but that's not possible. I'm
not aware of a more generic solution right now, but I'm open to ideas
:)

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc



More information about the llvm-commits mailing list