[llvm-commits] [llvm] r123040 - /llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp

Bob Wilson bob.wilson at apple.com
Fri Jan 7 15:31:13 PST 2011


On Jan 7, 2011, at 3:18 PM, Matt Beaumont-Gay wrote:

> Cc'ing the folks responsible for originally adding the assertion (in r123035).

I'll add something.

> 
> On Fri, Jan 7, 2011 at 14:45, Bill Wendling <wendling at apple.com> wrote:
>> On Jan 7, 2011, at 2:34 PM, Matt Beaumont-Gay wrote:
>> 
>>> Author: matthewbg
>>> Date: Fri Jan  7 16:34:58 2011
>>> New Revision: 123040
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=123040&view=rev
>>> Log:
>>> Eliminate variable only used in debug builds.
>>> 
>>> Modified:
>>>    llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
>>> 
>>> Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=123040&r1=123039&r2=123040&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
>>> +++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Fri Jan  7 16:34:58 2011
>>> @@ -3712,12 +3712,10 @@
>>>       // break it down again in a shuffle.
>>>       return SDValue();
>>>     }
>>> -
>>> -    unsigned SrcNumElts = SourceVecs[i].getValueType().getVectorNumElements();
>>> 
>>>     // Since only 64-bit and 128-bit vectors are legal on ARM and
>>>     // we've eliminated the other cases...
>>> -    assert(SrcNumElts == 2*NumElts);
>>> +    assert(SourceVecs[i].getValueType().getVectorNumElements() == 2*NumElts);
>>> 
>> Could you provide an explanation string with this assert?
>> 
>> -bw
>> 
>> 





More information about the llvm-commits mailing list