[llvm-commits] [PATCH][CMake] include/Config/config.h fixes.

arrowdodger 6yearold at gmail.com
Thu Jan 6 09:00:23 PST 2011


Posting first patch here as Óscar suggested in this thread
http://lists.cs.uiuc.edu/pipermail/llvmdev/2011-January/037209.html
I've decided to start with simple stuff.

Short summary:

- Add ENABLE_CBE_PRINTF_A.
- Fix ENABLE_PIC.
    The problem was that ENABLE_PIC was set to 1 *after* generating
config.h. I've moved if(ENABLE_PIC) from CMakeLists.txt into
cmake/config-ix.cmake.
- Add <ctype.h> check.
- Add fmodf() call check.
    This call located in math.h on Linux, FreeBSD, MacOS and Windows, so i
decided, that it's safe to check it using just check_symbol_exists()
command.
- Add HAVE_INT64_T.
- Fix HAVE_INT64_T, HAVE_UINT64_T and HAVE_U_INT64_T defines in
config.h.cmake.
- Remove CAN_DLOPEN_SELF.
    This was only in config.h.cmake and not in config.h.in. Additionaly,
there was none check for it.

I want to mention, that all CMake code is slightly messed up: declarations
are messed with logic, there is no convention on naming variables
(LLVM_ENABLE_<> and simply ENABLE_<>) and other things. What do you think
about cleaning this up?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110106/e96f2e4f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake.patch
Type: text/x-patch
Size: 5537 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110106/e96f2e4f/attachment.bin>


More information about the llvm-commits mailing list