[llvm-commits] [llvm] r122791 - /llvm/trunk/lib/Transforms/Scalar/LoopInstSimplify.cpp

[Cameron Zwarich]

On Jan 4, 2011, at 12:20 AM, Duncan Sands <baldrick at free.fr> wrote:

> Hi Cameron,
> 
>> Address most of Duncan's review comments. Also, make LoopInstSimplify a simple
>> FunctionPass. It probably doesn't have a reason to be a LoopPass, as it will
>> probably drop the simple fixed point and either use RPO iteration or Duncan's
>> approach in instsimplify of only revisiting instructions that have changed.
>> 
>> The next step is to preserve LoopSimplify. This looks like it won't be too hard,
>> although the pass manager doesn't actually seem to respect when non-loop passes
>> claim to preserve LCSSA or LoopSimplify. This will have to be fixed.
> 
> as far as I can see the pass is now identical to instsimplify, only it preserves
> LCSSA form.  In that case, why not delete the pass and teach instsimplify to
> preserve LCSSA form if it detects the presence of the LCSSA analysis?  However
> I think Chris is right and you should go back to having this be a loop pass.

Yes, that is what I will do. It also needs to preserve LoopSimplify.

Cameron
>