[llvm-commits] [Review request][Win] CMake & Lit: the new feature "LLVM_LIT_TOOLS_DIR"

NAKAMURA Takumi geek4civic at gmail.com
Sun Dec 26 17:46:15 PST 2010


Ping.


2010/12/7 Óscar Fuentes <ofv at wanadoo.es>:
>> +set(LLVM_LIT_TOOLS_DIR "" CACHE PATH "Path to GnuWin32 tools")
>
> I guess that other ports can be used (MSYS, Cygwin, etc) So instead of
> GnuWin32 maybe you should list the names of the required tools (cmp,
> sed, grep) on the docstring.
>
> +set(LLVM_LIT_TOOLS_DIR "" CACHE PATH
> +   "Path to GNU cmp, grep and sed. Used when running tests.")

I apologize to respond too later.

I intended, for it, easier case. It might be specified only for
gnuwin32 and would be useful on msbuild, mingw and msys.

On cygwin, lit.tools_dir would not be used. Cygwin's python does not
know he might be on win32 himself.
(and in general, cygwin's toolchain should be mature)


...Takumi




More information about the llvm-commits mailing list