[llvm-commits] [llvm] r122265 - /llvm/trunk/lib/Transforms/Utils/SimplifyInstructions.cpp

Duncan Sands baldrick at free.fr
Tue Dec 21 08:17:04 PST 2010

Hi Frits,

> I know this is intended primarily for testing, but maybe this should
> iterate until no changes were made just to be thorough? Or use a
> worklist so users of replaced values are re-examined later?
> Currently this pass depends on basic blocks order; IIRC
> SimplifyInstruction assumes the operands have already been simplified,
> which currently isn't necessarily the case if blocks don't happen to
> be topologically sorted (with respect to domination).

I added a worklist as you suggested in commit 122336.

Ciao, Duncan.

More information about the llvm-commits mailing list