[llvm-commits] [LLVMdev] PR 8199 - Can we get patches reviewed?

[Jason Kim]

On Wed, Dec 15, 2010 at 1:10 PM, David A. Greene <greened at obbligato.org> wrote:
> Jason Kim <jasonwkim at google.com> writes:
>
>> Hi David.
>>
>> Feedback below:
>
> Thanks!
>
>> 1. Please have one canonical list of executables (including things
>> like (elf/macho/coff)-dump that are used by test/ and prepend the
>> exact path to all of them, as having 3 sets of basically the same data
>> is not likely to be well received. Can you perhaps use word boundary
>> as a pattern check? (if you have to import re, so be it.)
>
> Ok.
>
>> 2. Add verbose comment to lit.cfg and TestRunner.py
>
> Ok.  What kind of comment would you like to see?  I'll add something
> about why we're doing the substitutions.  Anything else?

That should be good enough :-)

>
>> 5. File a doc bug to remind the core developers about this change (or
>> patch the doc directly?) You can do this separately.
>
> I'll do it at the same time.  It makes sense to keep it together.

Great!
Thanks!

-jason

>
>                                -Dave
>