[llvm-commits] [LLVMdev] PR 8199 - Can we get patches reviewed?

Jason Kim jasonwkim at google.com
Mon Dec 13 12:37:26 PST 2010


Hi David.

I think the regulars want the patches posted on llvm-commits for review
However, taking a  look at the second one (lit2.patch, attached),
there's couple of utilities missing in the list - like elf-dump etc.

I'd vote getting rid of the llvm-gcc bindir being prepended as the
easiest solution to fix this.
But I don't know WHY that path was being prepended in the first place.
(Perhaps someone with a longer memory then I can comment?)

If the list of executables changes, then the explicit list of known
tools need to change as well.
Problem is, I can't immediately think of a nice way to get the list of
generated execs exported to llvm-lit,

-jason

On Mon, Dec 13, 2010 at 11:34 AM, David Greene <dag at cray.com> wrote:
> I would like to see if we can get patches posted to PR 8199 reviewed
> ASAP.  These patches fix some problems with the lit tool and get the
> test suites working for me.  I won't be able to contribute any code
> until this PR gets resolved.
>
> Patch #1 or Patch #3 on the PR both fix the problem.  The difference in
> the patches is how ^ and $ are treated in substitution matching.  Read
> the bug comments for details.
>
> Thanks!
>
>                                -Dave
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lit2.patch
Type: text/x-patch
Size: 3022 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101213/cabea872/attachment.bin>


More information about the llvm-commits mailing list