[llvm-commits] [cfe-commits] [PATCH] CMake/tests: adding dependencies to "check" "check-all" (and "clang-test")

[Michael Spencer]

On Mon, Nov 29, 2010 at 12:01 PM, Óscar Fuentes <ofv at wanadoo.es> wrote:
> Hello Takumi.
>
> NAKAMURA Takumi <geek4civic at gmail.com> writes:
>
>> I committed "check-all" in clang r120280.
>>
>> As the next patch, I propose to add dependencies to "check"
>> "check-all" and "clang-test".
>>
>> I think it would be a good idea "check" and "check-all" could have
>> *right* dependencies on CMake,
>> though, they do not have any dependencies on autoconf make.
>
> Although the idea sounds like the Right Thing, in practice it slows down
> "make check" because it must ensure that all required dependencies are
> satisfied before running the tests. On some platforms (Windows/Visual
> Studio) that's a lot of time and even on fast Linux machines can be
> annoying.
>
> As I don't use "make check" too often, I'll left the final word to those
> who actually care.

I like these patches and would appreciate better dependency checking
for make check.

- Michael Spencer