[llvm-commits] [Review request][Win] CMake & Lit: the new feature "LLVM_LIT_TOOLS_DIR"

[Michael Spencer]

On Tue, Dec 7, 2010 at 5:28 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Good evening, guys!
>
> You can run tests on Visual Studio without adding anything to %PATH%.
> (to set LLVM_LIT_TOOLS_DIR and PYTHON_EXECUTABLE with CMake)
>
> You can run tests with gnuwin32 on both Mingw and MSYS.
>
> You can run tests on autoconf/MSYS with bash.
>
> Please give me any comments for this feature!
>
> This patch provides new features;
>
>  - Lit can pick up *sane* toolchain.
>    LitConfig.getToolsPath() can seek and pick up directory
>    where all of given commands [cmp, grep, sed] are in.
>    We ought never to meet C:/windows/system32/sort.exe etc.
>
>  - If the directory has "bash.exe", we can use bash shell for tests.
>    (even on Visual Studio! :p )
>    Even with configure, Lit can find bash.exe.
>    Note: Lit tests with MSYS have some issues.
>    You can work around it.
>
>  - You can specify LLVM_LIT_TOOLS_DIR.
>    Toolchain can be picked up from there.
>    Then you don't need to add gnuwin32 dir to %PATH%.
>    If MSYS bash.exe is there, bash tests will be executed.
>
> [llvm]
> * 0001-CMake-Add-the-new-option-LLVM_LIT_TOOLS_DIR.-It-.patch.txt
>
>  It adds the option "LLVM_LIT_TOOLS_DIR".
>  With CMake GUI, it can be set by directory chooser dialog.
>
>  It does nothing. It can be read from lit.config.lit_tools_dir.
>
> * 0002-lit-Util.py-Add-two-functions-checkToolsPath-dir.patch.txt
>
>  It adds two functions to Util.
>
> * 0003-lit-LitConfig.py-Add-the-new-method-getToolsPath.patch.txt
>
>  It adds a method to LitConfig. It depends to 0002.
>
> * 0004-test-lit.cfg-Seek-sane-tools-and-bash-in-directo.patch.txt
>
>  It activates LLVM_LIT_TOOLS_DIR.
>
> [clang]
> * 0001-test-CMake-Be-aware-of-LLVM_LIT_TOOLS_DIR.patch.txt
>
>  It activates LLVM_LIT_TOOLS_DIR.
>
>
> ...Takumi
>

I like them. Haven't had a chance to test yet, but I like the extra options.

- Michael Spencer