[llvm-commits] [llvm] r121119 - /llvm/trunk/lib/Support/DynamicLibrary.cpp

[Owen Anderson]

Author: resistor
Date: Tue Dec  7 01:56:20 2010
New Revision: 121119

URL: http://llvm.org/viewvc/llvm-project?rev=121119&view=rev
Log:
Don't leak the mutex when loading dynamic libraries.

Modified:
    llvm/trunk/lib/Support/DynamicLibrary.cpp

Modified: llvm/trunk/lib/Support/DynamicLibrary.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/DynamicLibrary.cpp?rev=121119&r1=121118&r2=121119&view=diff
==============================================================================
--- llvm/trunk/lib/Support/DynamicLibrary.cpp (original)
+++ llvm/trunk/lib/Support/DynamicLibrary.cpp Tue Dec  7 01:56:20 2010
@@ -61,17 +61,12 @@
 //===          independent code.
 //===----------------------------------------------------------------------===//
 
-static SmartMutex<true>* HandlesMutex;
 static std::vector<void *> *OpenedHandles = 0;
 
-static bool InitializeMutex() {
-  HandlesMutex = new SmartMutex<true>;
-  return HandlesMutex != 0;
-}
 
-static bool EnsureMutexInitialized() {
-  static bool result = InitializeMutex();
-  return result;
+static SmartMutex<true>& getMutex() {
+  static SmartMutex<true> HandlesMutex;
+  return HandlesMutex;
 }
 
 
@@ -88,8 +83,7 @@
   if (Filename == NULL)
     H = RTLD_DEFAULT;
 #endif
-  EnsureMutexInitialized();
-  SmartScopedLock<true> Lock(*HandlesMutex);
+  SmartScopedLock<true> Lock(getMutex());
   if (OpenedHandles == 0)
     OpenedHandles = new std::vector<void *>();
   OpenedHandles->push_back(H);
@@ -124,8 +118,7 @@
 
 #if HAVE_DLFCN_H
   // Now search the libraries.
-  EnsureMutexInitialized();
-  SmartScopedLock<true> Lock(*HandlesMutex);
+  SmartScopedLock<true> Lock(getMutex());
   if (OpenedHandles) {
     for (std::vector<void *>::iterator I = OpenedHandles->begin(),
          E = OpenedHandles->end(); I != E; ++I) {