[llvm-commits] [patch] ARM/MC/ELF RecordRelocation refactoring

[Rafael Espíndola]

> I thought about  adding new parameter(s) to GetRelocType, but given
> that these two (RelocSymbol and Addend) are already available as part
> of the ERE, it was a matter of adding two arguments just for the sake
> of MBlaze, or isolate the arch specific code within the single
> (renamed) function, and to pass the ERE directly (i.e. 1 addl' param).
> I chose the latter -

I would say adding const parameters to a "get" method is better than
turning it into a set. The signature of the first one makes it clear
what it can or cannot do.

> For now, I'll commit the first patch.

Thanks.

> Thanks
> -jason
>

Cheers,
Rafael