[llvm-commits] [Review request] Moving code from PHIElimination to MachineBasicBlock

[Jakob Stoklund Olesen]

On Dec 5, 2010, at 11:31 AM, Cameron Zwarich wrote:

> On Dec 5, 2010, at 10:38 AM, Chris Lattner wrote:
> 
>> On Dec 4, 2010, at 4:16 PM, Cameron Zwarich wrote:
>> 
>>> MachineBasicBlock should be responsible for the placement of phis in predecessor blocks, sparing PHIElimination the need to know the details. This will also let StrongPHIElimination share the code.
>> 
>> I don't have a strong opinion on this, but this function does seem pretty phi-elimination specific, and it seems strange for MBB.cpp to have to pull in MachineRegisterInfo.h.  If your goal is to share this between phi elimination implementation, it would probably be better in a PHIEliminationUtils.cpp file or something?
> 
> Here's an updated patch. Does it look okay?

Yes, looks good. Two points:

- Remember to update CMakeLists.txt when you add a new source file.
- I think our new coding standards want function names to begin with a lowercase letter.

/jakob

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101205/056bae96/attachment.bin>