[llvm-commits] [llvm] r119947 - /llvm/trunk/lib/Target/X86/README.txt

Chris Lattner clattner at apple.com
Mon Nov 29 15:12:18 PST 2010


On Nov 29, 2010, at 3:11 PM, Evan Cheng wrote:

> 
> On Nov 29, 2010, at 3:00 PM, Chris Lattner wrote:
> 
>> 
>> On Nov 29, 2010, at 2:57 PM, Evan Cheng wrote:
>> 
>>> Actually, this doesn't appear to be working on Darwin either. The issue is the call is turned into a fsin node and the "tailcall" property is apparently lost by the time legalizer expands it back into a call.  This needs to be fixed but I am not sure how.
>> 
>> Ah, I thought it was working for me.  It should always be safe to add this for sin/cos/etc.  The "tailcall" property just means that the callee is known to not access the callers stack frame.
> 
> Right, it should be safe to mark it tailcall when the node does not take a chain operand.

Yes, certainly!

-Chris





More information about the llvm-commits mailing list