[llvm-commits] [Review request] test: Add the new feature "loadable_module"

NAKAMURA Takumi geek4civic at gmail.com
Mon Nov 29 00:03:06 PST 2010


Hello Daniel,

I committed patches below as r120273 to r120276, and r120282, thank you.
* 0001-test-Add-the-new-feature-loadable_module.patch
* 0002-test-Use-SharedLibDir-for-loadable-modules.-On-Cygmi.patch
* 0004-tools-Makefile-Enable-building-lto-edis-and-bugpoint.patch
* 0005-test-Check-the-feature-loadable_module-with-load-mod.patch
* 0006-tools-Makefile-Fix-indentation.patch
I expect they would reduce a failure on xp-msvc9.

Indeed, "LLVMHello" might be so hacked. A patche is pending.

* 0003-Makefile-Change-the-order-of-building-lib-Transforms.patch

I have tried to tweak test/Feature/load_module.ll to use
BugpointPasses instead of LLVMHello,
and then I knew it might be redundant;

test/Feature/load_module.ll examines functionality of loading module,
grabbing option, and executing pass.
On ToT, they are done by test/BugPoint/. When test/BugPoint(s) pass,
Feature/load_module must pass.

My suggestion: May I remove test/Feature/load_module.ll ?
Then, we could move lib/Transforms/Hello to examples :)

...Takumi



More information about the llvm-commits mailing list