[llvm-commits] [llvm] r120277 - in /llvm/trunk: lib/Target/ARM/ARMInstrThumb.td test/MC/ARM/thumb.s

[Bill Wendling]

On Nov 28, 2010, at 7:59 PM, Chris Lattner wrote:

> On Nov 28, 2010, at 6:57 PM, Bill Wendling wrote:
> 
>> On Nov 28, 2010, at 6:28 PM, Chris Lattner wrote:
>> 
>>> 
>>> On Nov 28, 2010, at 4:42 PM, Bill Wendling wrote:
>>> 
>>>> Author: void
>>>> Date: Sun Nov 28 18:42:50 2010
>>>> New Revision: 120277
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=120277&view=rev
>>>> Log:
>>>> Add Thumb encodings for REV instructions.
>>> 
>>> Hi Bill,
>>> 
>>> I don't know thumb well, but shouldn't the Rm/Rd definitions be pulled up into T1pI?
>>> 
>> I just checked. The encoding isn't consistent enough to put the Rm/Rd defs into T1pI. There are several which are similar, though. So they might warrant a new base class.
> 
> Please change the users of T1pI to be consistent, then it should be safe to do this, thanks!
> 
Consistent in what way? Many have different operands and encodings from each other. It's not just a naming convention.

-bw